kbz_8/42_vox
1
0
Fork 0
mirror of https://github.com/Kbz-8/42_vox.git synced 2026-01-10 22:23:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixed std::floorf not found on 42 PCs && optimized GenerateWorld()

Browse Source 
In C++20, std::floor() automatically call it's float overload, and works on 42 PCs
Changed how x_range & y_range are declared to call a single .load() to avoid inconsistent data
I hoped the last change would fix crash when we move, but we just went from an illegal instruction to a segfault
This commit is contained in:
Namonay
2025-06-04 02:13:55 +02:00
parent b79f10a514
commit 17b577bfeb
1 changed files with 12 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
Application/World.cpp
View File

@@ -59,8 +59,8 @@ World::World(Scop::Scene& scene) : m_noisecollection(42), p_water_pipeline(std::
};
m_current_chunk_position = Scop::Vec2i{
static_cast<std::int32_t>(global_block_position.x < 0 ? std::floorf(global_block_position.x / static_cast<float>(CHUNK_SIZE.x)) : static_cast<float>(global_block_position.x) / static_cast<std::int32_t>(CHUNK_SIZE.x)),
static_cast<std::int32_t>(global_block_position.y < 0 ? std::floorf(global_block_position.y / static_cast<float>(CHUNK_SIZE.z)) : static_cast<float>(global_block_position.y) / static_cast<std::int32_t>(CHUNK_SIZE.z)),
static_cast<std::int32_t>(global_block_position.x < 0 ? std::floor(global_block_position.x / static_cast<float>(CHUNK_SIZE.x)) : static_cast<float>(global_block_position.x) / static_cast<std::int32_t>(CHUNK_SIZE.x)),
static_cast<std::int32_t>(global_block_position.y < 0 ? std::floor(global_block_position.y / static_cast<float>(CHUNK_SIZE.z)) : static_cast<float>(global_block_position.y) / static_cast<std::int32_t>(CHUNK_SIZE.z)),
};
if(Scop::NonOwningPtr<const Chunk> current_chunk = GetChunk(m_current_chunk_position); current_chunk)
@@ -180,9 +180,17 @@ void World::GenerateWorld()
}
std::queue<std::reference_wrapper<Chunk>> mesh_generation_queue;
Scop::Vec2i current_chunk = m_current_chunk_position.load();
Scop::Vec2i x_range{
current_chunk.x - RENDER_DISTANCE - 1,
current_chunk.x + RENDER_DISTANCE + 1
};
Scop::Vec2i z_range{
current_chunk.y - RENDER_DISTANCE - 1,
current_chunk.y + RENDER_DISTANCE + 1
};
Scop::Vec2i x_range{ m_current_chunk_position.load().x - RENDER_DISTANCE - 1, m_current_chunk_position.load().x + RENDER_DISTANCE + 1 };
Scop::Vec2i z_range{ m_current_chunk_position.load().y - RENDER_DISTANCE - 1, m_current_chunk_position.load().y + RENDER_DISTANCE + 1 };
std::size_t range = (RENDER_DISTANCE + RENDER_DISTANCE + 2) * 2;
m_loading_progress = 0.0f;