kbz_8/MacroLibX
1
0
Fork 0
mirror of https://github.com/seekrs/MacroLibX.git synced 2026-09-03 00:00:00 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fixed crash on NULL window titles + typo

Browse Source
This commit is contained in:
Daemo
2026-08-09 02:22:57 +02:00
parent f53d90e72c
commit 83b9f8f9da
3 changed files with 14 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
runtime/Includes/Core/Application.h
+1 -1
View File
@@ -23,7 +23,7 @@ namespace mlx
inline void OnEvent(mlx_window win, int event, void(*f)(int, void*), void* param) noexcept; inline void OnEvent(mlx_window win, int event, void(*f)(int, void*), void* param) noexcept;
inline mlx_window NewGraphicsSuport(const mlx_window_create_info* info); inline mlx_window NewGraphicsSupport(const mlx_window_create_info* info);
inline NonOwningPtr<GraphicsSupport> GetGraphicsSupport(mlx_window win); inline NonOwningPtr<GraphicsSupport> GetGraphicsSupport(mlx_window win);
inline void DestroyGraphicsSupport(mlx_window win); inline void DestroyGraphicsSupport(mlx_window win);
runtime/Includes/Core/Application.inl
+7 -2
View File
@@ -60,7 +60,7 @@ namespace mlx
m_fps.SetMaxFPS(fps); m_fps.SetMaxFPS(fps);
} }
mlx_window Application::NewGraphicsSuport(const mlx_window_create_info* info) mlx_window Application::NewGraphicsSupport(const mlx_window_create_info* info)
{ {
MLX_PROFILE_FUNCTION(); MLX_PROFILE_FUNCTION();
if(!info) if(!info)
@@ -68,6 +68,11 @@ namespace mlx
Error("invalid window create info (NULL)"); Error("invalid window create info (NULL)");
return nullptr; return nullptr;
} }
if (info->title == nullptr)
{
mlx::Error("invalid window title (NULL)");
return nullptr;
}
mlx_window window; mlx_window window;
try { window = new mlx_window_handler; } try { window = new mlx_window_handler; }
@@ -134,7 +139,7 @@ namespace mlx
{ {
m_hooks.emplace_back(f, param); m_hooks.emplace_back(f, param);
} }
void Application::LoopEnd() noexcept void Application::LoopEnd() noexcept
{ {
m_in.Finish(); m_in.Finish();
runtime/Sources/Core/Bridge.cpp
+6 -1
View File
@@ -61,7 +61,7 @@ extern "C"
mlx_window mlx_new_window(mlx_context mlx, const mlx_window_create_info* info) mlx_window mlx_new_window(mlx_context mlx, const mlx_window_create_info* info)
{ {
MLX_CHECK_APPLICATION_POINTER(mlx); MLX_CHECK_APPLICATION_POINTER(mlx);
return mlx->app->NewGraphicsSuport(info); return mlx->app->NewGraphicsSupport(info);
} }
void mlx_destroy_window(mlx_context mlx, mlx_window win) void mlx_destroy_window(mlx_context mlx, mlx_window win)
@@ -90,6 +90,11 @@ extern "C"
void mlx_set_window_title(mlx_context mlx, mlx_window win, const char* title) void mlx_set_window_title(mlx_context mlx, mlx_window win, const char* title)
{ {
if (title == nullptr)
{
mlx::Error("invalid window title (NULL)");
return;
}
MLX_CHECK_APPLICATION_POINTER(mlx); MLX_CHECK_APPLICATION_POINTER(mlx);
mlx::NonOwningPtr<mlx::GraphicsSupport> gs = mlx->app->GetGraphicsSupport(win); mlx::NonOwningPtr<mlx::GraphicsSupport> gs = mlx->app->GetGraphicsSupport(win);
if(!gs && !gs->HasWindow()) if(!gs && !gs->HasWindow())