From 52929e215c43124ca3ff7bdb89cfcc21dc92c5c9 Mon Sep 17 00:00:00 2001 From: Kbz-8 Date: Tue, 14 Nov 2023 07:22:38 +0100 Subject: [PATCH] fixing macos warning --- src/core/errors.cpp | 8 +++++--- src/renderer/buffers/vk_buffer.cpp | 11 ++++++----- 2 files changed, 11 insertions(+), 8 deletions(-) diff --git a/src/core/errors.cpp b/src/core/errors.cpp index d2b6155..0fb675b 100644 --- a/src/core/errors.cpp +++ b/src/core/errors.cpp @@ -6,7 +6,7 @@ /* By: maldavid +#+ +:+ +#+ */ /* +#+#+#+#+#+ +#+ */ /* Created: 2022/10/04 17:48:06 by maldavid #+# #+# */ -/* Updated: 2023/04/23 13:07:56 by maldavid ### ########.fr */ +/* Updated: 2023/11/14 07:14:57 by maldavid ### ########.fr */ /* */ /* ************************************************************************** */ @@ -17,15 +17,17 @@ #include "errors.h" +constexpr const int BUFFER_SIZE = 4096; + namespace mlx::core::error { void report(e_kind kind, std::string msg, ...) { - char buffer[4096]; + char buffer[BUFFER_SIZE]; va_list al; va_start(al, msg); - std::vsprintf(buffer, msg.c_str(), al); + std::vsnprintf(buffer, BUFFER_SIZE, msg.c_str(), al); va_end(al); switch(kind) diff --git a/src/renderer/buffers/vk_buffer.cpp b/src/renderer/buffers/vk_buffer.cpp index 7cacb41..99e4b77 100644 --- a/src/renderer/buffers/vk_buffer.cpp +++ b/src/renderer/buffers/vk_buffer.cpp @@ -6,7 +6,7 @@ /* By: maldavid +#+ +:+ +#+ */ /* +#+#+#+#+#+ +#+ */ /* Created: 2022/10/08 18:55:57 by maldavid #+# #+# */ -/* Updated: 2023/11/14 07:06:17 by maldavid ### ########.fr */ +/* Updated: 2023/11/14 07:17:06 by maldavid ### ########.fr */ /* */ /* ************************************************************************** */ @@ -65,13 +65,14 @@ namespace mlx bufferInfo.sharingMode = VK_SHARING_MODE_EXCLUSIVE; _name = name; + std::string alloc_name = _name; if(usage & VK_BUFFER_USAGE_INDEX_BUFFER_BIT) - _name.append("_index_buffer"); + alloc_name.append("_index_buffer"); else if(usage & VK_BUFFER_USAGE_VERTEX_BUFFER_BIT) - _name.append("_vertex_buffer"); + alloc_name.append("_vertex_buffer"); else if((usage & VK_BUFFER_USAGE_UNIFORM_BUFFER_BIT) != 1) - _name.append("_buffer"); - _allocation = Render_Core::get().getAllocator().createBuffer(&bufferInfo, &info, _buffer, _name.c_str()); + alloc_name.append("_buffer"); + _allocation = Render_Core::get().getAllocator().createBuffer(&bufferInfo, &info, _buffer, alloc_name.c_str()); _size = size; }